Skip to content

Fix: raise TypeError instead of return TypeError #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cgiovanetti merged 1 commit into from
Jan 26, 2026
Merged

Fix: raise TypeError instead of return TypeError #22

cgiovanetti merged 1 commit into from
Jan 26, 2026

Conversation

@smsharma
Copy link
Collaborator

@smsharma smsharma commented Jan 24, 2026

The Bug

File: linx/reactions.py, line 161

else:
    return TypeError('Must include spline data points or analytic...')

This returns a TypeError instance instead of raising it.

Impact

When a Reaction is created without providing either spline_data or frwrd_rate_param_func:

  1. __init__ returns a TypeError object (which is truthy, not an error)
  2. Object construction appears to "succeed"
  3. The reaction object is in an invalid state (missing required data)
  4. Causes cryptic failures later when the object is actually used

Example of the problem

# This SHOULD fail but doesn't:
rxn = Reaction(name="bad", in_states=(...), out_states=(...), 
               alpha=1, beta=2, gamma=3)
# rxn is now a TypeError instance, not a Reaction!

# Later code fails mysteriously:
rxn.frwrd_rate_param(T, p)  # AttributeError: 'TypeError' has no attribute...

The Fix

Change return TypeError(...) → raise TypeError(...)

🤖 Generated with Claude Code

@smsharma @claude
Fix: raise TypeError instead of return TypeError
be5a3c6 
BUG: Line 161 used `return TypeError(...)` instead of `raise TypeError(...)`.

This meant that when a Reaction was created without either spline_data
or frwrd_rate_param_func, the __init__ method would:
1. Return a TypeError instance (which is truthy, not an error)
2. Allow object construction to "succeed"
3. Cause cryptic failures later when the object is used

The fix changes `return` to `raise` so invalid Reaction construction
properly fails with a clear error message.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@smsharma smsharma requested a review from cgiovanetti January 24, 2026 02:30
cgiovanetti
cgiovanetti approved these changes Jan 26, 2026
View reviewed changes
Copy link
Owner

@cgiovanetti cgiovanetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@cgiovanetti cgiovanetti merged commit 71cd19c into main Jan 26, 2026
1 check passed
@cgiovanetti cgiovanetti deleted the siddharth/fix-raise-typeerror branch January 26, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgiovanetti cgiovanetti cgiovanetti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smsharma @cgiovanetti